apm: allow specifying transaction/span ID #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TransactionOptions.TransactionID and SpanOptions.SpanID to enable callers to specify transaction and span IDs. If those fields are valid/non-zero, they will be used; otherwise random values will be generated as usual.
Update ParseTraceparentHeader to validate the parsed trace and span IDs, ensuring that the returned TraceContext is valid if no error is returned. This is necessary to handle the case where a traceparent header is received containing a valid trace ID and an invalid span ID, which should cause a new trace to be started.
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 84.05% 84.01% -0.04%
==========================================
Files 108 108
Lines 6590 6608 +18
==========================================
+ Hits 5539 5552 +13
- Misses 763 765 +2
- Partials 288 291 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TransactionOptions.TransactionID and SpanOptions.SpanID
to enable callers to specify transaction and span IDs. If those fields
are valid/non-zero, they will be used; otherwise random values will
be generated as usual.
Closes #460
Closes #461