Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(jenkins): Install latest golang version for Windows #702

Merged
merged 2 commits into from
Jan 9, 2020
Merged

ci(jenkins): Install latest golang version for Windows #702

merged 2 commits into from
Jan 9, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 9, 2020

@v1v v1v self-assigned this Jan 9, 2020
@v1v v1v added the automation label Jan 9, 2020
@v1v v1v marked this pull request as ready for review January 9, 2020 11:02
@v1v v1v changed the title ci(jenkins): Install latest golang version ci(jenkins): Install latest golang version for Windows Jan 9, 2020
axw
axw approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cachedout
cachedout approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 9, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@14d69c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #702   +/-   ##
=========================================
  Coverage          ?   84.66%           
=========================================
  Files             ?      127           
  Lines             ?     8260           
  Branches          ?        0           
=========================================
  Hits              ?     6993           
  Misses            ?      887           
  Partials          ?      380

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d69c7...2be25d8. Read the comment docs.

@v1v v1v merged commit 4b3f304 into elastic:master Jan 9, 2020
@v1v v1v deleted the fix/latest-golang-windows branch January 9, 2020 13:02
v1v added a commit to v1v/apm-agent-go that referenced this pull request Jan 9, 2020
@v1v
Revert "ci(jenkins): Install latest golang version for Windows (elast…
769e357 
…ic#702)"

This reverts commit 4b3f304.
v1v added a commit that referenced this pull request Jan 10, 2020
@v1v
Revert "ci(jenkins): Install latest golang version for Windows (#702)" (
e0b15ea 
#703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

@axw axw axw approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@ElWPenn ElWPenn Awaiting requested review from ElWPenn

@kuisathaverat kuisathaverat Awaiting requested review from kuisathaverat

@mikemadden42 mikemadden42 Awaiting requested review from mikemadden42

Assignees

@v1v v1v

Labels
automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @codecov-io @cachedout @axw @mdelapenya