Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch SQLException when calling JDBC API from agent #1035

Merged
merged 15 commits into from
Mar 3, 2020

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Feb 13, 2020

What does this PR do?

This is an improvement on the previous fix #1006 that wraps all calls made by the agent to make sure that:

  • any thrown SQLException will mark the JDBC feature as not supported for the JDBC implementation.
  • avoid to trigger excessive logging and throwing exceptions at each JDBC call

Checklist

Author's Checklist

Related issues

@SylvainJuge SylvainJuge marked this pull request as ready for review February 13, 2020 18:03
@SylvainJuge SylvainJuge self-assigned this Feb 18, 2020
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test for potential performance degradation before merging

@SylvainJuge SylvainJuge removed the request for review from eyalkoren February 27, 2020 09:26
Keeping it 'as-is' is required in servlet plugin,
because tests fail for an unknown reason yet.
@SylvainJuge SylvainJuge merged commit 2e9e312 into elastic:master Mar 3, 2020
@SylvainJuge SylvainJuge deleted the catch-pokemon-jdbc-exceptions branch March 3, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants