Add trace_methods option #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines a syntax for matching methods which should be traced closes elastic#347
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
============================================
- Coverage 74.19% 72.46% -1.74%
+ Complexity 1429 1315 -114
============================================
Files 144 143 -1
Lines 5805 5048 -757
Branches 692 517 -175
============================================
- Hits 4307 3658 -649
+ Misses 1269 1154 -115
- Partials 229 236 +7
Continue to review full report at Codecov.
|
eyalkoren
reviewed
Dec 25, 2018
felixbarny
commented
Jan 7, 2019
| "NOTE: Only use wildcards if necessary.\n" + | ||
| "The more methods you match to more overhead will be caused by the agent.\n" + | ||
| "Also note that there is a maximum amount of spans per transaction (see <<config-transaction-max-spans, `transaction_max_spans`>>).") | ||
| .buildWithDefault(Collections.singletonList(MethodMatcher.of("org.springframework.web.servlet.DispatcherServlet#render(*, *, *)"))); |
There was a problem hiding this comment.
Remove default, that was just for testing purposes. When actually instrumenting DispatcherServlet#render, we probably want to set a custom type. Maybe template or render.
felixbarny
commented
Jan 7, 2019
.../src/test/java/co/elastic/apm/agent/bci/methodmatching/MethodMatcherInstrumentationTest.java
Show resolved
Hide resolved
eyalkoren
approved these changes
Jan 7, 2019
.../src/test/java/co/elastic/apm/agent/bci/methodmatching/MethodMatcherInstrumentationTest.java
Show resolved
Hide resolved
Add test cases to TraceMethodInstrumentationTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a syntax for matching methods which should be traced
closes #347