Skip to content

Commit

Permalink
chore: switch to transaction.type="scheduled" for timer-triggered Azu…
Browse files Browse the repository at this point in the history
…re Functions

From "timer". Neither value is in the APM agents shared spec, but
"scheduled" is prior art from some Java instrumentations (e.g. for
Quartz).

Refs: #3071
  • Loading branch information
trentm committed Jan 17, 2023
1 parent 82f1036 commit c5e472e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/instrumentation/azure-functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ const TRIGGER_TIMER = 3 // https://learn.microsoft.com/en-ca/azure/azure-functio
const TRANS_TYPE_FROM_TRIGGER_TYPE = {
[TRIGGER_OTHER]: 'request',
[TRIGGER_HTTP]: 'request',
// Note: `transaction.type = "timer"` is not in the shared APM agent spec yet.
[TRIGGER_TIMER]: 'timer'
// Note: `transaction.type = "scheduled"` is not in the shared APM agent spec,
// but the Java agent used the same value for some instrumentations.
[TRIGGER_TIMER]: 'scheduled'
}
// See APM spec and OTel `faas.trigger` at
// https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/faas/
Expand Down

0 comments on commit c5e472e

Please sign in to comment.