fix: change agent active status log message to debug level #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Qard what do you think of this change? It came up during my work on elastic/kibana#43548 because this message was logged when you for instance run Kibana from the terminal: |
Previously, the agent would log the following message on the info level
if `active: false`:
Elastic APM agent is inactive due to configuration
This proved problematic for CLI applications that ships with the agent
turned off by default.
In cases where `active` is set to `false` on purpose, it shouldn't be
necessary to log this message on the info level, instead we now log this
more specific message on the debug level:
Elastic APM agent disabled (`active` is false)
Qard
approved these changes
Aug 21, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the agent would log the following message on the info level if
active: false:This proved problematic for CLI applications that ships with the agent turned off by default.
In cases where
activeis set tofalseon purpose, it shouldn't be necessary to log this message on the info level, instead we now log this more specific message on the debug level: