refactor: clean up types slightly (drop GenericSpan, s/agent./apm./ namespace) #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docs - Drop the "GenericSpan" interface in our types. It isn't an external concept and there wasn't a lot of utility in using inheritance for it in the types file. - Change from 'agent.' to 'apm.' usage in the types test file because 'apm' is the prefix we encourage in docs (for good reason I think, it is less ambiguous).
github-actions
bot
added
the
agent-nodejs
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
|
I'm considering the checks green. The failure of Integration Tests is the unrelated, ongoing elastic/apm-integration-testing#1188 |
astorm
approved these changes
Aug 25, 2021
| @@ -127,31 +127,27 @@ declare namespace apm { | |||
| setSpanOutcome(outcome: Outcome): void; | |||
| } | |||
|
|
|||
| type Outcome = 'unknown' | 'success' | 'failure' | |||
| type Outcome = 'unknown' | 'success' | 'failure'; | |||
There was a problem hiding this comment.
Not necessary for this PR -- but seeing the added ; makes me wonder if we want to get some sort of auto-fix linter looking at these typescript files as well.
There was a problem hiding this comment.
Yah, agreed it would be nice, but I didn't want to go there in this PR.
dgieselaar
pushed a commit
to dgieselaar/apm-agent-nodejs
that referenced
this pull request
Sep 10, 2021
… docs (elastic#2300) - Drop the "GenericSpan" interface in our types. It isn't an external concept and there wasn't a lot of utility in using inheritance for it in the types file. - Change from 'agent.' to 'apm.' usage in the types test file because 'apm' is the prefix we encourage in docs (for good reason I think, it is less ambiguous).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concept and there wasn't a lot of utility in using inheritance for it
in the types file.
'apm' is the prefix we encourage in docs (for good reason I think, it
is less ambiguous).
This is a follow up to the types changes in #2119. I avoided this refactoring for that PR to keep the diff size down.
Checklist