Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix use of missing DOCKER_FOLDER var that breaks CI test cleanup #2304

Merged
merged 3 commits into from
Aug 26, 2021
Merged

ci: fix use of missing DOCKER_FOLDER var that breaks CI test cleanup #2304

merged 3 commits into from
Aug 26, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Aug 25, 2021

A change introduced in #2184 used the DOCKER_FOLDER var that had been removed
in earlier #2087. The result was the test cleanup's docker-compose down ...
failing.

E.g. from https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/master/1037/pipeline/160

[2021-08-24T06:02:42.888Z] docker_node_tests_1 exited with code 0
[2021-08-24T06:02:42.888Z] Aborting on container exit...
[2021-08-24T06:02:42.888Z] + NODE_VERSION=12
[2021-08-24T06:02:42.888Z] + docker-compose --no-ansi --log-level ERROR -f /docker-compose-all.yml down -v --remove-orphans
[2021-08-24T06:02:43.829Z] .FileNotFoundError: [Errno 2] No such file or directory: '/docker-compose-all.yml'
[2021-08-24T06:02:43.829Z] + echo 'Unexpected error in '\''docker-compose down ...'\''. Forcing removal of unused networks.'
[2021-08-24T06:02:43.829Z] Unexpected error in 'docker-compose down ...'. Forcing removal of unused networks.
[2021-08-24T06:02:43.829Z] + docker network inspect docker_default
[2021-08-24T06:02:43.829Z] [
[2021-08-24T06:02:43.829Z]     {
[2021-08-24T06:02:43.829Z]         "Name": "docker_default",
[2021-08-24T06:02:43.829Z]         "Id": "71941065c9ade7f7a38551313ee2bf4ec08918f558e91c291cb15c5ca90ffcf7",
[2021-08-24T06:02:43.829Z]         "Created": "2021-08-24T05:53:52.779150585Z",
[2021-08-24T06:02:43.829Z]         "Scope": "local",
[2021-08-24T06:02:43.829Z]         "Driver": "bridge",
[2021-08-24T06:02:43.829Z]         "EnableIPv6": false,

Notice the -f /docker-compose-all.yml argument to docker-compose.

@trentm
ci: fix use of missing DOCKER_FOLDER var that breaks CI test cleanup
a8ca8b4 
A change introduced in #2184 used the DOCKER_FOLDER var that had been removed
in earlier #2087. The result was the test cleanup's `docker-compose down ...`
failing
@trentm trentm self-assigned this Aug 25, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 25, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Aug 25, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-25T22:06:47.431+0000

  • Duration: 18 min 22 sec

  • Commit: 5065dfa

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

Trends 🧪

Image of Build Times

Image of Tests

@trentm
Copy link
Member Author

trentm commented Aug 25, 2021

This shows a build step working properly with the fix, from https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2304/1/pipeline/182

...
[2021-08-25T21:04:54.713Z] docker_node_tests_1 exited with code 0
[2021-08-25T21:04:54.713Z] Aborting on container exit...
[2021-08-25T21:04:54.713Z] .ci/scripts/test.sh:255: main(): NODE_VERSION=12.0
[2021-08-25T21:04:54.713Z] .ci/scripts/test.sh:255: main(): docker-compose --no-ansi --log-level ERROR -f .ci/docker/docker-compose-all.yml down -v --remove-orphans
[2021-08-25T21:04:56.104Z] Stopping docker_memcached_1     ... 
[2021-08-25T21:04:56.104Z] Stopping docker_postgres_1      ... 
[2021-08-25T21:04:56.104Z] Stopping docker_cassandra_1     ... 
[2021-08-25T21:04:56.104Z] Stopping docker_mysql_1         ... 
[2021-08-25T21:04:56.104Z] Stopping docker_redis_1         ... 
[2021-08-25T21:04:56.104Z] Stopping docker_mongodb_1       ... 
[2021-08-25T21:04:56.104Z] Stopping docker_localstack_1    ... 
[2021-08-25T21:04:56.104Z] Stopping docker_mssql_1         ... 
[2021-08-25T21:04:56.105Z] Stopping docker_elasticsearch_1 ... 
[2021-08-25T21:04:56.694Z] Stopping docker_postgres_1      ... done
[2021-08-25T21:04:56.695Z] Stopping docker_redis_1         ... done
[2021-08-25T21:04:56.695Z] Stopping docker_mongodb_1       ... done
[2021-08-25T21:04:56.956Z] Stopping docker_mssql_1         ... done
[2021-08-25T21:04:56.956Z] Stopping docker_elasticsearch_1 ... done
[2021-08-25T21:04:57.531Z] Stopping docker_mysql_1         ... done
[2021-08-25T21:04:58.930Z] Stopping docker_cassandra_1     ... done
[2021-08-25T21:04:58.930Z] Stopping docker_memcached_1     ... done
[2021-08-25T21:05:07.086Z] Stopping docker_localstack_1    ... done
[2021-08-25T21:05:07.086Z] Removing docker_node_tests_1    ... 
[2021-08-25T21:05:07.086Z] Removing docker_memcached_1     ... 
[2021-08-25T21:05:07.087Z] Removing docker_postgres_1      ... 
[2021-08-25T21:05:07.087Z] Removing docker_cassandra_1     ... 
[2021-08-25T21:05:07.087Z] Removing docker_mysql_1         ... 
[2021-08-25T21:05:07.087Z] Removing docker_redis_1         ... 
[2021-08-25T21:05:07.087Z] Removing docker_mongodb_1       ... 
[2021-08-25T21:05:07.087Z] Removing docker_localstack_1    ... 
[2021-08-25T21:05:07.087Z] Removing docker_mssql_1         ... 
[2021-08-25T21:05:07.087Z] Removing docker_elasticsearch_1 ... 
[2021-08-25T21:05:07.087Z] Removing docker_postgres_1      ... done
[2021-08-25T21:05:07.087Z] Removing docker_mysql_1         ... done
[2021-08-25T21:05:07.087Z] Removing docker_elasticsearch_1 ... done
[2021-08-25T21:05:07.087Z] Removing docker_cassandra_1     ... done
[2021-08-25T21:05:07.087Z] Removing docker_redis_1         ... done
[2021-08-25T21:05:07.087Z] Removing docker_memcached_1     ... done
[2021-08-25T21:05:07.087Z] Removing docker_mssql_1         ... done
[2021-08-25T21:05:07.087Z] Removing docker_localstack_1    ... done
[2021-08-25T21:05:07.087Z] Removing docker_mongodb_1       ... done
[2021-08-25T21:05:07.087Z] Removing docker_node_tests_1    ... done

@trentm trentm requested a review from astorm August 25, 2021 23:00
@trentm
Copy link
Member Author

trentm commented Aug 25, 2021

^^^ Integration Tests failure doesn't "count": I'm blaming it on elastic/apm-integration-testing#1188

@trentm trentm merged commit af05f35 into master Aug 26, 2021
@trentm trentm deleted the trentm/no-DOCKER_FOLDER branch August 26, 2021 23:47
dgieselaar pushed a commit to dgieselaar/apm-agent-nodejs that referenced this pull request Sep 10, 2021
@trentm @dgieselaar
ci: fix use of missing DOCKER_FOLDER var that breaks CI test cleanup (e…
7f5623a 
…lastic#2304)

A change introduced in elastic#2184 used the DOCKER_FOLDER var that had been removed
in earlier elastic#2087. The result was the test cleanup's `docker-compose down ...`
failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorm astorm astorm approved these changes

Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trentm @apmmachine @astorm