Change composer installation in docker #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Cannot find autoconf
mdelapenya
approved these changes
Aug 17, 2020
v1v
commented
Aug 17, 2020
| @@ -13,8 +13,7 @@ RUN apt-get -qq update \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" \ | |||
| && php -r "if (hash_file('sha384', 'composer-setup.php') === 'e5325b19b381bfd88ce90a5ddb7823406b2a38cff6bb704b0acc289a09c8128d4a8ce2bbafcd1fcbdc38666422fe2806') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;" \ | |||
| && php composer-setup.php --install-dir=/usr/bin --filename=composer \ | |||
| && php composer-setup.php --install-dir=/usr/bin --filename=composer --version=1.10.10 \ | |||
There was a problem hiding this comment.
Being predictable with a specific version of the composer to be installed.
SergeyKleyman
approved these changes
Aug 17, 2020
v1v
added a commit
to v1v/apm-agent-php
that referenced
this pull request
Aug 18, 2020
* upstream/master: Add ENVIRONMENT configuration option Change composer installation in docker (elastic#128) Add tests/APM_Agents_shared directory [packaging] support multiple PHP API (elastic#121) [Packaging] restore php.ini if something bad happened (elastic#116) [CI] Cosmetic changes in the stage names (elastic#115)
v1v
added a commit
to v1v/apm-agent-php
that referenced
this pull request
Aug 19, 2020
…utomation-tag-based * upstream/master: Support APK with FPM (elastic#92) Add ENVIRONMENT configuration option Change composer installation in docker (elastic#128) Add tests/APM_Agents_shared directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the current issue when the composer version has changed but the sha512sum not!
Why
Being reproducible and trust the docker composer image
Further references
See https://getcomposer.org/doc/faqs/how-to-install-composer-programmatically.md#how-do-i-install-composer-programmatically-