feat: migrate handler to modelpb and prepare for decoder migration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2023
kruskall
force-pushed
the
feat/migrate-handler-pb
branch
from
96655b3
to
96a1c77
Compare
axw
approved these changes
Jun 15, 2023
input/elasticapm/internal/modeldecoder/modeldecodertest/populator.go
Outdated
Show resolved
Hide resolved
kruskall
force-pushed
the
feat/migrate-handler-pb
branch
2 times, most recently
from
58f65e7
to
58ba292
Compare
kruskall
force-pushed
the
feat/migrate-handler-pb
branch
from
513d8dd
to
f7cf6ee
Compare
|
signing requirements 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for migrating the decoder to protobuf:
One of the test is relying on reflection and it's doesn't work well with protobuf so I've skipped it for now.
Related to #52
Blocked by #60