chore: switch standard to eslint (#203)

.eslintrc.json

@@ -0,0 +1,27 @@
+{
+  "root": true,
+  "env": {
+    "node": true
+  },
+  "extends": "standard",
+  "plugins": [
+    "license-header"
+  ],
+  "rules": {
+    "license-header/header": ["error", "./scripts/license-header.js"],
+    // Regarding "no-var": The opinion of this repository's maintainers is that
+    // while const/let are useful, the use of `var` is not bad and therefore
+    // does not need to be ruled out. Eliminating the use of `var` would be a
+    // large diff that (a) could theoretically cause bugs due to lexical scoping
+    // changes and (b) could theoretically impact perf (e.g. see
+    // https://github.com/microsoft/TypeScript/issues/52924). New code MAY
+    // prefer const/let over `var`. Code in "examples/" MUST use const/let --
+    // this is enforced by "examples/.eslintrc.json".
+    "no-var": "off"
+  },
+  "ignorePatterns": [
+    "/*.example.js", // a pattern for uncommited local dev files to avoid linting
+    "/*.example.mjs", // a pattern for uncommited local dev files to avoid linting
+    "/.nyc_output"
+  ]
+}

index.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const assert = require('assert')
@@ -555,8 +561,8 @@ Client.prototype._writeBatch = function (objs, cb) {
     this._slowWriteBatch.numOver10Ms++
   }
   this._log.trace({
-    encodeTimeMs: encodeTimeMs,
-    fullTimeMs: fullTimeMs,
+    encodeTimeMs,
+    fullTimeMs,
     numEvents: objs.length,
     numBytes: chunk.length
   }, '_writeBatch')
@@ -1188,7 +1194,8 @@ function getChoppedStreamHandler (client, onerror) {
       log.trace('gzipStream "finish"')
       if (!completedFromPart.intakeReq && !completedFromPart.intakeRes) {
         const timeout = (client._writableState.ending || intakeRequestGracefulExitCalled
-          ? intakeResTimeoutOnEnd : intakeResTimeout)
+          ? intakeResTimeoutOnEnd
+          : intakeResTimeout)
         log.trace({ timeout }, 'start intakeResTimer')
         intakeResTimer = setTimeout(() => {
           completePart('intakeRes',
@@ -1450,7 +1457,7 @@ function getConfigRequestOptions (opts, agent) {
 
 function getBasicRequestOptions (method, defaultPath, headers, opts, agent) {
   return {
-    agent: agent,
+    agent,
     rejectUnauthorized: opts.rejectUnauthorized !== false,
     ca: opts.serverCaCert,
     hostname: opts.serverUrl.hostname,

lib/central-config.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Central config-related utilities for the APM http client.

lib/container-info.js

@@ -1,7 +1,9 @@
 /*
- * Copyright (c) 2018 Stephen Belanger
  * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
  */
+
 'use strict'
 
 const fs = require('fs')

lib/detect-hostname.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Detect the current hostname, preferring the FQDN if possible.

lib/logging.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Logging utilities for the APM http client.

lib/ndjson.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const stringify = require('fast-safe-stringify')

lib/truncate.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 var breadthFilter = require('breadth-filter')

package.json

@@ -10,7 +10,8 @@
     "lib"
   ],
   "scripts": {
-    "lint": "standard",
+    "lint": "eslint --ext=js,mjs,cjs . # requires node >=16.0.0",
+    "lint:fix": "eslint --ext=js,mjs,cjs --fix .  # requires node >=16.0.0",
     "test": "nyc node ./scripts/run-tests.js"
   },
   "engines": {
@@ -30,10 +31,15 @@
     "stream-chopper": "^3.0.1"
   },
   "devDependencies": {
+    "eslint": "^8.42.0",
+    "eslint-config-standard": "^17.1.0",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-license-header": "^0.6.0",
+    "eslint-plugin-n": "^16.0.1",
+    "eslint-plugin-promise": "^6.1.1",
     "glob": "^7.2.3",
     "ndjson": "^1.5.0",
     "nyc": "^14.1.1",
-    "standard": "^14.3.1",
     "tape": "^4.11.0"
   },
   "repository": {

scripts/license-header.js

@@ -0,0 +1,5 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */

test/abort.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/apm-server-version.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Test that fetching the APM Server version works as expected.

test/backoff-delay.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Test Client.prototype._getBackoffDelay.

test/basic.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/central-config.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/config.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const fs = require('fs')

test/container-info.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const fs = require('fs')

test/edge-cases.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const { exec } = require('child_process')

test/expectExtraMetadata.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Test usage of `expectExtraMetadata: true` and `setExtraMetadata()`.

test/extraMetadata.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Test usage of `extraMetadata: ...`.

test/fixtures/cgroup_result.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 module.exports = {

test/k8s.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/lambda-usage.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // Test the expected usage of this Client in an AWS Lambda environment.

test/lib/call-me-back-maybe.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 // A script, used by test/side-effects.js, to test that the client.flush
 // callback is called.
 //
@@ -17,7 +23,7 @@ const serverUrl = process.argv[2]
 
 const client = new Client({
   // logger: require('pino')({ level: 'trace', ...require('@elastic/ecs-pino-format')() }, process.stderr), // uncomment for debugging
-  serverUrl: serverUrl,
+  serverUrl,
   serviceName: 'call-me-back-maybe',
   agentName: 'my-nodejs-agent',
   agentVersion: '1.2.3',

test/lib/unref-client.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 // This is used in test/side-effects.js to ensure that a Client with a

test/lib/utils.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const http = require('http')

test/metadata-filter.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/side-effects.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const path = require('path')

test/stringify.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/truncate.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')

test/writev.test.js

@@ -1,3 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and other contributors where applicable.
+ * Licensed under the BSD 2-Clause License; you may not use this file except in
+ * compliance with the BSD 2-Clause License.
+ */
+
 'use strict'
 
 const test = require('tape')