Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix ambiguous *.output documentation #3093

Merged
merged 6 commits into from
Jan 9, 2020

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 30, 2019

For #2580.

Requires a PR in the Beats repo to persist the changes: elastic/beats#15272.


This PR adds a paragraph to each output page explaining that the es output must be disabled first:

To use this output, edit the {beatname_uc} configuration file to disable the {es}
output by commenting it out...

It also clarifies that for apm-server, Logstash and Kafka enabled defaults to false. This is not the case for beats:

ifndef::apm-server[]
The default value is `true`.
endif::[]
ifdef::apm-server[]
The default value is `false`.
endif::[]

Finally, there is no redis, file, or console section in the .yml configuration files, so I've fixed wording that indicated there was.

@bmorelli25 bmorelli25 force-pushed the ambiguous-kafka-logstash-docs branch from 3131239 to dbc3cce Compare January 9, 2020 00:37
@bmorelli25
Copy link
Member Author

Going to merge this. Let me know if you see anything after the fact that needs fixing.

@bmorelli25 bmorelli25 merged commit a035970 into elastic:master Jan 9, 2020
@bmorelli25 bmorelli25 deleted the ambiguous-kafka-logstash-docs branch January 9, 2020 01:00
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 9, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 9, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 13, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant