intake: Add rows_affected to span db information #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to include number of rows affected by a sql database statement in the db information of a span. closes elastic#2802
Codecov Report
@@ Coverage Diff @@
## master #3095 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 97 97
Lines 4985 4985
=======================================
Hits 3930 3930
Misses 1055 1055 |
|
@simitt Thank you for letting me know. Regarding your question:
I think this field should be searchable and aggregatable to allow users for example to find out how many DB rows transactions affect on average and which transactions affect more DB rows than 95th percentile, etc. |
axw
approved these changes
Jan 6, 2020
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jan 6, 2020
Allow to include number of rows affected by a sql database statement in the db information of a span. closes elastic#2802
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jan 6, 2020
Allow to include number of rows affected by a sql database statement in the db information of a span. closes elastic#2802
simitt
added a commit
that referenced
this pull request
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As layed out in elastic/apm#112 we want to include the number of rows affected by a sql database statement manipulating db data in the available database information of a span.
As this is not currently used in any aggregation, and described as additional information to be shown to users, the field is not indexed. @SergeyKleyman please let me know if you had in mind that this field should be search or aggregatable.Update: the new field is indexed as Elasticsearch long, according to #3095 (comment).
closes #2802