[7.x] Migrate to Go modules (#3418) #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add go.mod - Add tools.go for tracking build/test tools in go.mod - Update Makefile to use go.mod, instead of vendor - Update beats imports to use "beats/v7" - Update cespare/xxhash to use "xxhash/v2" - Copy reviewdog.yml from beats - Copy build scripts from beats/dev-tools - Remove vendor and _beats - Fork generate_notice.py -- needed because we do not (can not) use vendoring - Update beats framework to bbf9d6697f4a; adapt to several breaking changes in libbeat - tests/system: use "go list" to find libbeat - Modify "update-beats" target to rsync libbeat/testing/environments into apm-server/testing/environments. We could alternatively just go our own way, but this is fairly easy to maintain for now. - Update tests/Dockerfile to remove GOPATH, and prime the container with the module dependencies by copying in "go.mod" and running "go mod download".
Codecov Report
@@ Coverage Diff @@
## 7.x #3466 +/- ##
=======================================
Coverage 79.03% 79.03%
=======================================
Files 109 109
Lines 5724 5724
=======================================
Hits 4524 4524
Misses 1200 1200 |
The eslegclient changes have not been backported to 7.x (yet?), so this commit reverts those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: