-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add span reparenting field child_ids #3679
Conversation
Even though it was in the proposal, I'm not sure about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on child.id
, but would like to hear @simitt's thoughts given her recent ECS research. Otherwise LGTM.
Good call. I pushed the change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO child
is the right term here. What makes it confusing is that parent
now doesn't actually mean parent anymore but can refer to any predecessor. A child's event can have another parent, that breaks my parent/child logic. Since parent.id
is used for the waterfall UI (afaik) I don't think we could easily change that though, so LGTM.
Motivation/summary
Span reparenting intake. Closes #3422
Checklist
make check-full
for static code checks and linting)How to test these changes
Related issues