Tidy up beater/config #5376
Merged
Tidy up beater/config #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove some "setup" methods, set default values before unpacking - unexport DefaultKibanaAgentConfig - de-pointer various config fields to avoid the need for nil-pointer checks, and rely on default values; remove "IsEnabled" methods in favour of setting default values for Enabled fields - move various config types into their own files - remove dead validator code
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Jun 1, 2021
| } | ||
|
|
||
| func (s *AgentConfig) setup() error { | ||
| if !s.Service.isValid() { |
There was a problem hiding this comment.
The validation checks for service are preventing kibana-generated apm-server configs from starting, since selecting "name=all" and "envirohnment=all" results in service being marshaled as {} (978acd4). Adding this as a note in case there's a conflict between PRs.
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Tidy up beater/config - remove some "setup" methods, set default values before unpacking - unexport DefaultKibanaAgentConfig - de-pointer various config fields to avoid the need for nil-pointer checks, and rely on default values; remove "IsEnabled" methods in favour of setting default values for Enabled fields - move various config types into their own files - remove dead validator code * beater/config: remove now-pointless test (cherry picked from commit b0c4307)
axw
added a commit
that referenced
this pull request
Jun 1, 2021
* Tidy up beater/config - remove some "setup" methods, set default values before unpacking - unexport DefaultKibanaAgentConfig - de-pointer various config fields to avoid the need for nil-pointer checks, and rely on default values; remove "IsEnabled" methods in favour of setting default values for Enabled fields - move various config types into their own files - remove dead validator code * beater/config: remove now-pointless test (cherry picked from commit b0c4307) Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
How to test these changes
N/A, non-functional change.
Related issues
Setting up for implementing #5347