-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce apm-server.auth.*
config
#5457
Conversation
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errorsExpand to view the steps failures
|
f43315f
to
410009c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Introduce the new AgentAuth config structure, which holds API Key and secret token auth. Later we will add "anonymous" auth here too. We also introduce a new YAML naming scheme for the config, `apm-server.auth.*`. The old config is deprecated and copied across to the new config fields.
@bmorelli25 would you please take a look at the docs changes? I've renamed some config, and added new deprecation sections for the deprecated config names. I've also moved "api_key.* configuration options" into the "API keys" section, not sure if it was intentional that it was separate? I can move back if you prefer, but then I'm not sure where the deprecation section should go. |
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the apmpackage
please. I suggest we remove the deprecated settings and only support the new ones.
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look great–thanks!
It looks like there's one additional change that needs to be made to the command reference file. I'll fix that in the Beats repo and copy it over to apm-server before 7.14.
Failure is related to the beats update, which will be resolved by #5471 |
* Introduce `apm-server.auth.*` config Introduce the new AgentAuth config structure, which holds API Key and secret token auth. Later we will add "anonymous" auth here too. We also introduce a new YAML naming scheme for the config, `apm-server.auth.*`. The old config is deprecated and copied across to the new config fields. * docs: update config names * apmpackage: update auth config keys (cherry picked from commit fc60576) # Conflicts: # changelogs/head.asciidoc
* Introduce `apm-server.auth.*` config (#5457) * Introduce `apm-server.auth.*` config Introduce the new AgentAuth config structure, which holds API Key and secret token auth. Later we will add "anonymous" auth here too. We also introduce a new YAML naming scheme for the config, `apm-server.auth.*`. The old config is deprecated and copied across to the new config fields. * docs: update config names * apmpackage: update auth config keys (cherry picked from commit fc60576) Co-authored-by: Andrew Wilkins <axw@elastic.co>
* Introduce `apm-server.auth.*` config Introduce the new AgentAuth config structure, which holds API Key and secret token auth. Later we will add "anonymous" auth here too. We also introduce a new YAML naming scheme for the config, `apm-server.auth.*`. The old config is deprecated and copied across to the new config fields. * docs: update config names * apmpackage: update auth config keys (cherry picked from commit fc60576) # Conflicts: # apmpackage/apm/agent/input/template.yml.hbs # beater/config/config.go # beater/jaeger/server.go # beater/processors.go # beater/server.go # changelogs/head.asciidoc
Tested with BC2:
|
Motivation/summary
Introduce the new AgentAuth config structure, which holds API Key and secret token auth. Later we will add "anonymous" auth here too, and deprecate/replace some RUM config (rate limiting and allowed service names).
We also introduce a new YAML naming scheme for the config,
apm-server.auth.*
. The old config is deprecated and copied across to the new config fields.Checklist
How to test these changes
apm-server.secret_token
andapm-server.api_key.*
, make sure they are honoured (e.g. query "GET /" with/out auth)apm-server.auth.secret_token
andapm-server.auth.api_key.*
, same again.Related issues
#5347