Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global labels to spans #153

Closed
felixbarny opened this issue Sep 27, 2019 · 9 comments
Closed

Add global labels to spans #153

felixbarny opened this issue Sep 27, 2019 · 9 comments

Comments

@felixbarny
Copy link
Member

Currently, global labels are only added to transactions, metrics, and errors. There are several requests for enabling global labels for spans too.

The latest one: https://discuss.elastic.co/t/labels-are-getting-added-to-only-transaction-event-not-to-span-event/201069/

Some other use cases:

@felixbarny
Copy link
Member Author

The environment will be added to all spans as of 7.4: elastic/apm-server#2471

IMHO, it would be consistent to do the same for global labels. Does someone have objections in terms of disk usage? I don't expect that users would add lots and lots of global labels. And if they add them, they generally want to be able to filter by those labels.

@Qard
Copy link

Qard commented Sep 30, 2019

Personally, I'm all for consistency. The less differences between transactions and spans the better.

@nehaduggal
Copy link

Filtering spans by labels has come up in multiple user conversations. In most cases its users wanting to add just a couple of labels(at the most)to track specific end to end user actions.

@felixbarny
Copy link
Member Author

Based on the comments here and in today's meeting, it seems like there's agreement that this should be done. @graphaelli could you create an APM Server issue and put it in a milestone?

@ramya-govind
Copy link

When can I expect this change? In which release it will be updated?

@graphaelli
Copy link
Member

Issue created but milestone decision is still pending, feel free to follow the linked issue.

@jalvz
Copy link
Contributor

jalvz commented Oct 16, 2019

This will go out in 7.6.

elastic/apm-server#2806

@jalvz
Copy link
Contributor

jalvz commented Oct 18, 2019

Server support has been merged. If agents do not need a new API or anything, this issue can be closed.

@axw
Copy link
Member

axw commented Oct 18, 2019

AFAIK, they do not. We can reopen if needed.

@axw axw closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants