Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include service.environment on spans #2471

Closed
roncohen opened this issue Jul 17, 2019 · 2 comments · Fixed by #2500
Closed

Include service.environment on spans #2471

roncohen opened this issue Jul 17, 2019 · 2 comments · Fixed by #2500
Assignees
Milestone

Comments

@roncohen
Copy link
Contributor

Today we don't include service.environment on spans. We do include service.name. Unfortunately, due to the existence of service.environment, using only service.name does not fully identify a service. We should add service.environment so it's also included in all spans.

@simitt
Copy link
Contributor

simitt commented Jul 26, 2019

At the moment service.name can be overwritten on a per event basis in the Intake API. I assume adding service.environment to a span also requires allowing to overwrite this property, as it could lead to inconsistent service data otherwise. @felixbarny afair you have been asking for overwriting fields back then, do you agree on allowing to overwrite per event?

Update: the environment would most probably be the same per request, so ignore this comment.

simitt added a commit to simitt/apm-server that referenced this issue Jul 26, 2019
@felixbarny
Copy link
Member

There’s no option in the Java agent to allow for multiple environments in one JVM and we don’t have plans for that.

simitt added a commit to simitt/apm-server that referenced this issue Jul 26, 2019
@simitt simitt self-assigned this Jul 26, 2019
simitt added a commit that referenced this issue Jul 26, 2019
* Add service.environment to spans.

closes #2471
simitt added a commit to simitt/apm-server that referenced this issue Jul 26, 2019
* Add service.environment to spans.

closes elastic#2471
simitt added a commit that referenced this issue Jul 29, 2019
* Add service.environment to spans.

closes #2471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants