Skip to content

Commit

Permalink
enable cgo and fix typecheck linter (#33649)
Browse files Browse the repository at this point in the history
  • Loading branch information
fearful-symmetry authored and chrisberkhout committed Jun 1, 2023
1 parent f42a414 commit f3536b3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- name: golangci-lint
env:
GOOS: ${{ matrix.GOOS }}
CGO_ENABLED: 1
uses: golangci/golangci-lint-action@v3
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
Expand Down
7 changes: 6 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ issues:
- text: "ST1003:"
linters:
- stylecheck
- text: "undefined"
linters:
- typecheck
- text: "imported but not used"
linters:
- typecheck
# From mage we are priting to the console to ourselves
- path: (.*magefile.go|.*dev-tools/mage/.*)
linters: forbidigo
Expand All @@ -42,7 +48,6 @@ linters:
- govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
- ineffassign # detects when assignments to existing variables are not used
- structcheck # finds unused struct fields
- typecheck # Like the front-end of a Go compiler, parses and type-checks Go code
- varcheck # Finds unused global variables and constants
- asciicheck # simple linter to check that your code does not contain non-ASCII identifiers
- bodyclose # checks whether HTTP response body is closed successfully
Expand Down

0 comments on commit f3536b3

Please sign in to comment.