Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back -d publish behavior #11053

Closed
wants to merge 1 commit into from
Closed

Bring back -d publish behavior #11053

wants to merge 1 commit into from

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 4, 2019

Traditionally, passing the -d publish debug selector to a Beat caused events to be printed to the log.

After recent changes, it is required to also add the publisher selector, probably by mistake.

@adriansr
Bring back -d publish behavior
c171d71 
Traditionally, passing the `-d publish` debug selector to a Beat
caused events to be printed to the log.

After recent changes, it is required to also add the `publisher`
selector, probably by mistake.
@adriansr adriansr added review libbeat needs_backport PR is waiting to be backported to other branches. labels Mar 4, 2019
@adriansr adriansr requested a review from urso March 4, 2019 00:23
@adriansr adriansr requested a review from a team as a code owner March 4, 2019 00:23
@urso
Copy link

urso commented Mar 4, 2019

We actually have 2 pipeline instances with different logger names publisher, and monitoring. Part of the problem is logp.IsDebug("publish") inside the publisher pipeline.

PR #10801 removes the logp.IsDebug("publish") in favor of asking the logger instance passed in. With #10801 one can either use -d publisher, or -d monitoring to print the events of one or the other subsystem.

@adriansr
Copy link
Contributor Author

adriansr commented Mar 4, 2019

Thanks @urso, I wasn't aware of #10801. I will close this PR and use -d publisher from now own.

@adriansr adriansr closed this Mar 4, 2019
@adriansr adriansr deleted the lb_fix_debug_publish branch March 4, 2019 14:54
@adriansr adriansr removed the needs_backport PR is waiting to be backported to other branches. label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

@urso urso Awaiting requested review from urso

Assignees
No one assigned
Labels
libbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @urso @kvch