Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] Remove redundant mage targets in metricbeat generator magefile #13341

Merged

Conversation

fearful-symmetry
Copy link
Contributor

This is a first pass at pairing down the magefiles a bit. We already have a lot of stuff duplicated in target/, so this just removes anything we already have somewhere else. Most of the target names should be the same, however a few like GoTestIntegration have changed.

@fearful-symmetry fearful-symmetry added Metricbeat Metricbeat :Generator Related to code generators for building custom Beats or modules. technical_debt labels Aug 26, 2019
@fearful-symmetry fearful-symmetry requested review from a team August 26, 2019 03:23
@fearful-symmetry fearful-symmetry self-assigned this Aug 26, 2019
@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Aug 26, 2019
@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

@kaiyan-sheng
Copy link
Contributor

hmm ci failed with Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [heartbeat/docs/fields.asciidoc heartbeat/include/fields.go]

@fearful-symmetry
Copy link
Contributor Author

What? Did I break something?

@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

@kvch
Copy link
Contributor

kvch commented Aug 28, 2019

Just curious, does the generated Beat rely on both make and mage?

@fearful-symmetry
Copy link
Contributor Author

@kvch More or less everything depends simultaneously on make and mage. The two actually depend on each other. Make will all mage, mage will call make. Yah, it's ugly and I'd there's lots of things I'd like to refactor.

@fearful-symmetry fearful-symmetry merged commit 3bb13a1 into elastic:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Generator Related to code generators for building custom Beats or modules. Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants