Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting generator.py to mage #13610

Merged
merged 34 commits into from
Oct 18, 2019

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Sep 11, 2019

This is a draft as it still has a ways to go.

Right now, we're more or less at feature parity with the existing python script. The goal is to have it also replace the functionality of make setup as well, since that's a one-time operation that doesn't really need to be a separate command.

  • Add setup commands
  • add type validation checks
  • change user docs
  • update makefiles
  • remove old python
  • update tests
  • update the beat template stuff while we're at it

@fearful-symmetry fearful-symmetry added :Generator Related to code generators for building custom Beats or modules. technical_debt labels Sep 11, 2019
@fearful-symmetry fearful-symmetry requested review from a team September 11, 2019 20:49
@fearful-symmetry fearful-symmetry self-assigned this Sep 11, 2019
@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Sep 11, 2019
@fearful-symmetry
Copy link
Contributor Author

So, this is far from done, but now we at least have all the setup commands we need ported over to mage. This will make it easier to standardize the beat/metricbeat make files, and should reduce some amount of boilerplate.

@fearful-symmetry
Copy link
Contributor Author

Okay, my attempts to add some useful features like a dev vendor copy and also a vendor update seemed to be...more complicated than I expected.

@fearful-symmetry
Copy link
Contributor Author

Slowly working on porting the test. This commit will fail Ci due to #13741. Other than that, the tests should be working with the mage script.

@fearful-symmetry
Copy link
Contributor Author

Okay, this should pass CI. Should.

@fearful-symmetry
Copy link
Contributor Author

Alright, there we go. The make tests aren't working on my laptop, but they're working on CI.

@fearful-symmetry fearful-symmetry force-pushed the port-newbeat-mage branch 3 times, most recently from bc4fd5d to 6730378 Compare September 25, 2019 17:24
@fearful-symmetry
Copy link
Contributor Author

Did a quick update to the devguide.

@fearful-symmetry
Copy link
Contributor Author

Okay, this is about ready to go out of draft. The only thing that still bugs me is the design of the generator config, and I feel like it should be a struct instead of a map. The idea is that if we need to add configuration items later down the line, it's sort of a one-step process that requires you to just add an item to that map.

@fearful-symmetry fearful-symmetry marked this pull request as ready for review September 26, 2019 15:47
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner September 26, 2019 15:47
@fearful-symmetry
Copy link
Contributor Author

CI is related to the ongoing libbeat CI issues.

@fearful-symmetry fearful-symmetry changed the title WiP: converting generator.py to mage Converting generator.py to mage Sep 27, 2019
@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

1 similar comment
@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

@fearful-symmetry fearful-symmetry merged commit 3d93735 into elastic:master Oct 18, 2019
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Generator Related to code generators for building custom Beats or modules. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants