Compare event by event in testdata framework to avoid sorting problems
#13747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sorting problems Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
enhancement
Metricbeat
ChrsMark
changed the title
testdata framework to avoid sorting problems
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
approved these changes
Sep 20, 2019
Signed-off-by: chrismark <chrismarkou92@gmail.com>
|
Failing test seems to be irrelevant (libbeat) and it is also failing for other PRs too. Merging since Metricbeat tests finished successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
testdatawe currently assert the final lists of events, which need to be sorted otherwise the assertion will fail. This leads to problematic situations when one want to useremove_fields_from_comparisonin long lists of events since the sorting are not working properly.In this regard, it might be safer in the long run to compare event by event the lists, as we do in
beats/metricbeat/helper/prometheus/ptest/ptest.go
Line 105 in 8ce4b7c