Stop using mage:import in custom beats #14162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
:Generator
mage:import doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of mage:import from the magefiles intended to be used by custom beats.
jsoriano
force-pushed
the
remove-mage-import-custom-beats
branch
from
af3a16d
to
08e3c18
Compare
jsoriano
added
needs_backport
|
It looks like we're missing a bunch of the |
I wouldn't care about them. Before using |
|
It looks like we're still importing |
Agree, I will add |
fearful-symmetry
approved these changes
Oct 21, 2019
|
Failing tests happening in filebeat only, not related, merging and backporting this. |
|
Thanks @fearful-symmetry for the review! |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 22, 2019
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats. (cherry picked from commit af5e812)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Oct 25, 2019
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats. (cherry picked from commit af5e812)
This was referenced Jan 8, 2020
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
`mage:import` doesn't take into account vendorized dependencies, this is a problen for custom beats, because by default they have libbeat as a vendorized dependency. The solution would be to use go modules, but in the meantime lets remove the use of `mage:import` from the magefiles intended to be used by custom beats. (cherry picked from commit 4001f92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mage:importdoesn't take into account vendorized dependencies, this is aproblen for custom beats, because by default they have libbeat as a
vendorized dependency. The solution would be to use go modules, but in
the meantime lets remove the use of
mage:importfrom the magefilesintended to be used by custom beats.
Fix #13998