Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for intel.log zeek module #14404

Merged
merged 10 commits into from
Nov 19, 2019
Merged

Conversation

garanews
Copy link
Contributor

@garanews garanews commented Nov 7, 2019

Enrich the #14150 supporting intel.log

Co-Authored-By: Arcuri Davide dadokkio@gmail.com

@garanews garanews requested a review from a team as a code owner November 7, 2019 10:03
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any log samples that can be included in the fileset for testing purposes? Those can be placed in zeek/intel/test/*.log.

garanews and others added 6 commits November 18, 2019 15:44
Enrich the elastic#14150 supporting intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
example intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
added default_field: false

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed an update to add the generated test log output and a changelog entry.

@andrewkroh
Copy link
Member

jenkins, test this

@andrewkroh
Copy link
Member

jenkins, test this

Expand dots in zeek.intel.seen
Parse ts value without dropping millisecond value
Add event.ingested timestamp
Convert ingest node pipeline to YAML
Save JSON message in event.original
Expand dots of all seen.* fields
Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek.
@andrewkroh
Copy link
Member

jenkins, test this

Will wait for CI to test these changes again then I'll merge it. Thanks!

@andrewkroh andrewkroh merged commit 7ad14e6 into elastic:master Nov 19, 2019
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Nov 19, 2019
* Added support for intel.log zeek module

Enrich the elastic#14150 supporting intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* Update fields.yml

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* intel.log

example intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* added default_field: false

added default_field: false

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* Generate expected zeek/intel output event

* Add changelog entry

* Update field docs

* Misc improvements

Expand dots in zeek.intel.seen
Parse ts value without dropping millisecond value
Add event.ingested timestamp
Convert ingest node pipeline to YAML
Save JSON message in event.original

* Updates to zeek.intel.seen

Expand dots of all seen.* fields
Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek.

* Update field docs

(cherry picked from commit 7ad14e6)
andrewkroh added a commit that referenced this pull request Nov 22, 2019
* Added support for intel.log zeek module

Enrich the #14150 supporting intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* Update fields.yml

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* intel.log

example intel.log

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* added default_field: false

added default_field: false

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>

* Generate expected zeek/intel output event

* Add changelog entry

* Update field docs

* Misc improvements

Expand dots in zeek.intel.seen
Parse ts value without dropping millisecond value
Add event.ingested timestamp
Convert ingest node pipeline to YAML
Save JSON message in event.original

* Updates to zeek.intel.seen

Expand dots of all seen.* fields
Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek.

* Update field docs

(cherry picked from commit 7ad14e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants