[libbeat] Fix dropped queue feature metadata / remove unused helper #17666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrc
added
[zube]: Inbox
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
urso
approved these changes
Apr 15, 2020
6 tasks
faec
added a commit
to faec/beats
that referenced
this pull request
Apr 16, 2020
…lastic#17666) (cherry picked from commit a067c4a)
faec
added a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Feature metadata for queues was being defined in the code but then discarded rather than passed to the registration call. This also gave the impression of registry setup happening twice when in fact only one call took effect. This PR cleans up the queue registry helper functions and fixes the call sites.
This PR has no user-visible effects.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.