Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields validation for histogram subfields #17759

Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 16, 2020

What does this PR do?

Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

Why is it important?

To avoid needing to add exceptions or additional mappings to the Prometheus
module or to modules based on it (as in #17736).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.
@jsoriano jsoriano added enhancement review needs_backport PR is waiting to be backported to other branches. :Testing [zube]: In Review Team:Platforms Label for the Integrations - Platforms team v7.8.0 labels Apr 16, 2020
@jsoriano jsoriano self-assigned this Apr 16, 2020
@jsoriano
Copy link
Member Author

Failure in libbeat is #17768, failures in Mac OS X don't seem related.

@jsoriano
Copy link
Member Author

jenkins, test this again.

@jsoriano
Copy link
Member Author

jenkins, test this again please

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix!

@jsoriano jsoriano merged commit 5983411 into elastic:master Apr 17, 2020
@jsoriano jsoriano deleted the prometheus-check-fields-light-modules branch April 17, 2020 10:15
jsoriano added a commit to jsoriano/beats that referenced this pull request Apr 17, 2020
Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

(cherry picked from commit 5983411)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Apr 17, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Apr 17, 2020
Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

(cherry picked from commit 5983411)
jsoriano added a commit that referenced this pull request Apr 21, 2020
Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

(cherry picked from commit 5983411)
jsoriano added a commit that referenced this pull request Apr 21, 2020
…lds (#17786)

Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

(cherry picked from commit 5983411)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
… subfields (elastic#17786)

Add validation to histogram subfields in a way that they don't need to
be added to the mappings, but they can still be checked. This is helpful
to avoid having to add exceptions to all the modules based on Prometheus
when Elasticsearch types are used.

(cherry picked from commit 4912b78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants