Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Moved stream.* fields to top of event #17858

Merged
merged 6 commits into from
Apr 22, 2020
Merged

[Elastic-Agent] Moved stream.* fields to top of event #17858

merged 6 commits into from
Apr 22, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 21, 2020 •
edited
Loading

What does this PR do?

Modifies generated add_fields processor to include stream fields to top level not under fields.*

Why is it important?

It is required

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@michalpristas michalpristas mentioned this pull request Apr 21, 2020
Closed
ruflin
ruflin approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could we have also some test for this as a follow up to make sure our events look as expected long term. Not sure how this fits into our current testing frameworks.

ph
ph approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 21, 2020
@ph ph changed the title [Agent] Moved stream.* fields to top of event [Elastic-Agent] Moved stream.* fields to top of event Apr 21, 2020
@ruflin ruflin mentioned this pull request Apr 22, 2020
Merged
@michalpristas michalpristas merged commit 677d2e2 into elastic:master Apr 22, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Apr 22, 2020
@michalpristas
[Elastic-Agent] Moved stream.* fields to top of event (elastic#17858)
2b8d04a 
[Elastic-Agent] Moved stream.* fields to top of event (elastic#17858)
@michalpristas michalpristas mentioned this pull request Apr 22, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request Apr 22, 2020
@michalpristas
[Elastic-Agent] Moved stream.* fields to top of event (#17858) (#17892)
b30778c 
[Elastic-Agent] Moved stream.* fields to top of event (#17858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
bug needs_backport PR is waiting to be backported to other branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @ph @ruflin