Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18878 to 7.x: [Filebeat] Remove references to non-existent Zeek signatures fileset #19041

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

andrewkroh
Copy link
Member

Cherry-pick of PR #18878 to 7.x branch. Original message:

What does this PR do?

In #13683, a signatures fileset is enabled, but it did not exist. This removes
it from the module.d/zeek.yml config file so that the module can start.

In #12812 there was a signatures fileset but that PR never merged. Perhaps
the fileset from that closed PR can be brought into master.

Why is it important?

The module doesn't start under the default config because of the missing fileset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

)

In elastic#13683, a `signatures` fileset is enabled, but it did not exist. This removes
it from the module.d/zeek.yml config file so that the module can start.

In elastic#12812 there was a signatures fileset but that PR never merged. Perhaps
the fileset from that closed PR can be brought into master.

Relates: #18868
(cherry picked from commit 229aee0)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request elastic/beats#19041 opened]

  • Start Time: 2020-06-08T16:58:24.749+0000

  • Duration: 46 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 1716
Skipped 255
Total 1971

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2020
@andrewkroh andrewkroh merged commit 9ca2fbd into elastic:7.x Jun 8, 2020
@andrewkroh andrewkroh deleted the backport_18878_7.x branch January 14, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants