Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin golang.org/x/tools to release-branch1.13 #19478

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Pin golang.org/x/tools to release-branch1.13 #19478

merged 1 commit into from
Jun 29, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 29, 2020

What does this PR do?

This PR pins golang.org/x/tools to the 1.13 release branch to avoid lint errors showing up every day. When we adopt go1.14, we have to update it to release-branch1.14.

Why is it important?

ATM master is failing due to the everyday updates to golang.org/x/tools.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 29, 2020
michalpristas
michalpristas approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad it gets aligned

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19478 opened]

  • Start Time: 2020-06-29T06:21:57.265+0000

  • Duration: 26 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 540
Skipped 127
Total 667

@kvch kvch merged commit e5c6905 into elastic:master Jun 29, 2020
@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Jun 29, 2020
@zube zube bot added [zube]: Done needs_backport PR is waiting to be backported to other branches. and removed [zube]: In Review needs_backport PR is waiting to be backported to other branches. labels Jun 29, 2020
@kvch kvch removed the needs_backport PR is waiting to be backported to other branches. label Jun 29, 2020
kvch added a commit to kvch/beats that referenced this pull request Jun 29, 2020
@kvch
Fix golang.org/x/tools to release1.13 (elastic#19478)
7afe833
@jsoriano jsoriano mentioned this pull request Jun 29, 2020
Merged
6 tasks
kvch added a commit that referenced this pull request Jun 29, 2020
@kvch
Cherry-pick #18655 to 7.x: Remove vendor folder from the repository (#…
c806e5b 
…19477)

* Remove vendor folder from repository (#18655)

To update or add a dependency use the standard tools provided by Golang.
(cherry picked from commit 5426df0)

* Fix golang.org/x/tools to release1.13 (#19478)
v1v added a commit to v1v/beats that referenced this pull request Jul 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-o…
c57b3ae 
…ne-beats

* upstream/master: (105 commits)
  ci: enable packaging job (elastic#19536)
  ci: disable upstream trigger on PRs for the packaging job (elastic#19490)
  Implement memlog on-disk handling (elastic#19408)
  fix go.mod for PR elastic#19423 (elastic#19521)
  [MetricBeat] add param `aws_partition` to support aws-cn, aws-us-gov regions (elastic#19423)
  Input v2 stateless manager (elastic#19406)
  Input v2 compatibility layer (elastic#19401)
  [Elastic Agent] Fix artifact downloading to allow endpoint-security to be downloaded (elastic#19503)
  fix: ignore target changes on scans (elastic#19510)
  Add more helpers to pipeline/testing package (elastic#19405)
  Report dependencies in CSV format (elastic#19506)
  [Filebeat] Fix reference leak in TCP and Unix socket inputs (elastic#19459)
  Cursor input skeleton (elastic#19378)
  Add changelog. (elastic#19495)
  [DOC] Typo in Kerberos (elastic#19265)
  Remove accidentally commited unused NOTICE template (elastic#19485)
  [Elastic Agent] Support the install, control, and uninstall of Endpoint (elastic#19248)
  [Filebeat][httpjson] Add split_events_by config setting (elastic#19246)
  ci: disabling packaging job until we fix it (elastic#19481)
  Fix golang.org/x/tools to release1.13 (elastic#19478)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kvch @melchiormoulin
Fix golang.org/x/tools to release1.13 (elastic#19478)
5cd6a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees
No one assigned
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kvch @elasticmachine @michalpristas @andresrc