Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20127 to 7.x: Fix failing unit tests on windows #20181

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Cherry-pick #20127 to 7.x: Fix failing unit tests on windows #20181

merged 5 commits into from
Jul 23, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20127 to 7.x branch. Original message:

What does this PR do?

Fixes failures of action store on windows due to unclosed readers across the codebase.

Why is it important?

To have action store work properly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #19919

@michalpristas
[Ingest Manager] Fix failing unit tests on windows (elastic#20127)
e0870f7 
* remove skip

* close properly

* changelog

* space
@michalpristas michalpristas self-assigned this Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 23, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20181 updated]

  • Start Time: 2020-07-23T18:14:17.077+0000

  • Duration: 50 min 59 sec

blakerouse
blakerouse requested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix changelog.

This also has a test failing.

blakerouse
blakerouse approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit 85d07ae into elastic:7.x Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
backport bug Ingest Management:beta1 Group issues for ingest management beta1 review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @blakerouse