Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make implementing Close required by reader.Reader #20455

Merged
merged 11 commits into from
Aug 13, 2020
Merged

Make implementing Close required by reader.Reader #20455

merged 11 commits into from
Aug 13, 2020

Commits on Aug 11, 2020

  1. Make implementing Close required by reader.Readers 

    Closes elastic#19193
    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c0c9844 View commit details
    Browse the repository at this point in the history

  2. fix lint job

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c8ed72a View commit details
    Browse the repository at this point in the history

  3. add changelog entry

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4f6fc1c View commit details
    Browse the repository at this point in the history

  4. add empty Close functions to unit tests

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    eb76506 View commit details
    Browse the repository at this point in the history

  5. make default operation a case

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e75f4d9 View commit details
    Browse the repository at this point in the history

  6. fix timeout reader

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0c1d265 View commit details
    Browse the repository at this point in the history

  7. reword changelog entry

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4649a38 View commit details
    Browse the repository at this point in the history

  8. use return

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f7d5ff1 View commit details
    Browse the repository at this point in the history

  9. set multiline reader to closed state

    @kvch
    kvch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    233aec3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. return error on done

    @kvch
    kvch committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    253aa33 View commit details
    Browse the repository at this point in the history

  2. add missing impotr

    @kvch
    kvch committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    b4678bb View commit details
    Browse the repository at this point in the history