[Elastic Agent] Fix agent composable processor promotion to fix duplicates #22344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
botelastic
bot
added
the
needs_team
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
exekias
approved these changes
Nov 2, 2020
botelastic
bot
added
Team:Ingest Management
and removed
needs_team
4 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Nov 2, 2020
…cates (elastic#22344) * Fix agent composable processor promotion to fix duplicates. * Add changelog entry. (cherry picked from commit 3d4cc25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the processor promotion from a dynamic composable inputs provider to after duplicate checking has occurred. This ensures that the same input is not duplicated with different processors added from dynamic input.
Why is it important?
With the
kubernetesdynamic composable input provider, it can cause duplicate inputs to be created because it can match onkubernetes.pod.idacross all containers, each with different processors information. Only the very first one should be matched the duplicates should be ignored (even though the processor information is different).Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues