Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Management] Fixed parsing of npipe URI #22978

Merged
merged 2 commits into from
Dec 9, 2020
Merged

[Ingest Management] Fixed parsing of npipe URI #22978

merged 2 commits into from
Dec 9, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Dec 8, 2020 •
edited
Loading

What does this PR do?

Fixed parsing of http+npipe uris used by agent.

Why is it important?

Fixes: #22957
Blocking: #22394

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 8, 2020
@michalpristas michalpristas changed the title [Ingest Management] Fixed parsing of npipe uris [Ingest Management] Fixed parsing of npipe URI Dec 8, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22978 event

  • Start Time: 2020-12-08T09:37:51.845+0000

  • Duration: 61 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 17361
Skipped 1373
Total 18734

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17361
Skipped 1373
Total 18734

@ph ph requested a review from blakerouse December 8, 2020 14:29
@ph
Copy link
Contributor

ph commented Dec 8, 2020

Would like to get input from @blakerouse my knowledge of npipe permissions are limited.

blakerouse
blakerouse approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

npipe permissions look correct

@michalpristas michalpristas merged commit ad57c73 into elastic:master Dec 9, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Dec 9, 2020
@michalpristas
[Ingest Management] Fixed parsing of npipe URI (elastic#22978)
50362d5 
[Ingest Management] Fixed parsing of npipe URI (elastic#22978)
@michalpristas michalpristas mentioned this pull request Dec 9, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request Dec 9, 2020
@michalpristas
[Ingest Management] Fixed parsing of npipe URI (#22978) (#23014)
e063ded 
[Ingest Management] Fixed parsing of npipe URI (#22978)
@viszsec
Copy link

viszsec commented Sep 8, 2022

this issues reoccur with elastic agent 8.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest Management] Monitoring metrics using npipe does not work
5 participants
@michalpristas @elasticmachine @ph @viszsec @blakerouse