Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Do not take ownership of Endpoint log path #23444

Merged
merged 3 commits into from
Jan 12, 2021
Merged

[Elastic-Agent] Do not take ownership of Endpoint log path #23444

merged 3 commits into from
Jan 12, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jan 12, 2021 •
edited
Loading

What does this PR do?

No longer takes ownership of the log path when the program spec file defines custom log paths.

Why is it important?

When custom log paths are used they do not exist with in the same path of Elastic Agent, so ownership of those files should not be changed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added the Team:Elastic-Agent Label for the Agent team label Jan 12, 2021
@blakerouse blakerouse self-assigned this Jan 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@blakerouse blakerouse changed the title [Elastic-Agent] Do not take ownership when custom log path is defined in spec [Elastic-Agent] Do not take ownership of Endpoint log path Jan 12, 2021
michalpristas
michalpristas approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 12, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23444 updated

  • Start Time: 2021-01-12T15:29:53.583+0000

  • Duration: 30 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

@blakerouse blakerouse merged commit 71e406b into elastic:master Jan 12, 2021
@blakerouse blakerouse deleted the fix-23441 branch January 12, 2021 16:00
@blakerouse blakerouse mentioned this pull request Jan 12, 2021
Merged
3 tasks
blakerouse added a commit to blakerouse/beats that referenced this pull request Jan 12, 2021
@blakerouse
[Elastic-Agent] Do not take ownership of Endpoint log path (elastic#2…
726829c 
…3444)

* Do not take ownership when custom log path is defined in spec.

* Add changelog.

* Empty commit.

(cherry picked from commit 71e406b)
blakerouse added a commit to blakerouse/beats that referenced this pull request Jan 12, 2021
@blakerouse
[Elastic-Agent] Do not take ownership of Endpoint log path (elastic#2…
8ebfbe8 
…3444)

* Do not take ownership when custom log path is defined in spec.

* Add changelog.

* Empty commit.

(cherry picked from commit 71e406b)
@blakerouse blakerouse mentioned this pull request Jan 12, 2021
Merged
3 tasks
blakerouse added a commit that referenced this pull request Jan 12, 2021
@blakerouse
[Elastic-Agent] Do not take ownership of Endpoint log path (#23444) (#…
545cbac 
…23445)

* Do not take ownership when custom log path is defined in spec.

* Add changelog.

* Empty commit.

(cherry picked from commit 71e406b)
blakerouse added a commit that referenced this pull request Jan 12, 2021
@blakerouse
[Elastic-Agent] Do not take ownership of Endpoint log path (#23444) (#…
999d47a 
…23446)

* Do not take ownership when custom log path is defined in spec.

* Add changelog.

* Empty commit.

(cherry picked from commit 71e406b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels
Team:Elastic-Agent Label for the Agent team v7.11.0 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Agent] macOS Agent goes unhealthy due to chown call made to Endpoint log file during start up
3 participants
@blakerouse @elasticmachine @michalpristas