Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Skip top level files when unziping archive during upgrade #23456

Merged
merged 2 commits into from
Jan 12, 2021
Merged

[Ingest Manager] Skip top level files when unziping archive during upgrade #23456

merged 2 commits into from
Jan 12, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jan 12, 2021 •
edited
Loading

What does this PR do?

Fixes codepath for top level files which was completely incorrect.

Why is it important?

Upgrade working properly, without this it leads to incorrect paths generation and target files wont be found

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Jan 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 12, 2021
@michalpristas michalpristas changed the title [Ingest Manager] skip top level files [Ingest Manager] Skip top level files when unziping archive during upgrade Jan 12, 2021
This was referenced Jan 12, 2021
Merged
Merged
Merged
@michalpristas michalpristas added the needs_backport PR is waiting to be backported to other branches. label Jan 12, 2021
blakerouse
blakerouse approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23456 updated

  • Start Time: 2021-01-12T18:25:13.363+0000

  • Duration: 27 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

@michalpristas michalpristas merged commit f9df249 into elastic:master Jan 12, 2021
michalpristas added a commit that referenced this pull request Jan 12, 2021
@michalpristas
Cherry-pick #23456 to 7.10: Skip top level files when unziping archiv…
aacf9ec 
…e during upgrade (#23459)

* skip top level files

* Update CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta2 Group issues for ingest management beta2 needs_backport PR is waiting to be backported to other branches. v7.10.2 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @blakerouse