Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Capture the rollover files for logging #23514

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jan 14, 2021

What does this PR do?

Fixes an issue where logs where not being collected by the filebeat monitor.

Why is it important?

So rollover log files are captured by the filebeat monitor.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added the Team:Elastic-Agent Label for the Agent team label Jan 14, 2021
@blakerouse blakerouse self-assigned this Jan 14, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 14, 2021
@blakerouse blakerouse marked this pull request as ready for review January 14, 2021 17:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23514 updated

    • Start Time: 2021-01-14T17:48:51.853+0000
  • Duration: 32 min 53 sec

  • Commit: a296aee

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1422
Skipped 4
Total 1426

@blakerouse blakerouse merged commit 72eb969 into elastic:master Jan 14, 2021
@blakerouse blakerouse deleted the fix-agent-monitor-log branch January 14, 2021 18:49
blakerouse added a commit to blakerouse/beats that referenced this pull request Jan 14, 2021
* Capture the rollover files for logging.

* Add changelog.

(cherry picked from commit 72eb969)
blakerouse added a commit to blakerouse/beats that referenced this pull request Jan 14, 2021
* Capture the rollover files for logging.

* Add changelog.

(cherry picked from commit 72eb969)
blakerouse added a commit that referenced this pull request Jan 15, 2021
* Capture the rollover files for logging.

* Add changelog.

(cherry picked from commit 72eb969)
blakerouse added a commit that referenced this pull request Jan 15, 2021
* Capture the rollover files for logging.

* Add changelog.

(cherry picked from commit 72eb969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants