[Elastic Agent] Increase checkin grace period. #23568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
Pinging @elastic/agent (Team:Agent) |
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jan 19, 2021
* Include checkin grace period. * Add changelog entry. (cherry picked from commit 2f50f9e)
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jan 19, 2021
* Include checkin grace period. * Add changelog entry. (cherry picked from commit 2f50f9e)
blakerouse
added a commit
that referenced
this pull request
Jan 20, 2021
blakerouse
added a commit
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase the checkin grace period from 2 seconds to 30 seconds.
Why is it important?
Because the grace period is 2 seconds, it is possible that on a system that has enough load that between Agent and Endpoint checking in, it's possible that the grace period is not enough. Increasing the grace period doesn't really cause a negative effect, so its better to increase it so on systems with load degraded does not occur just because the process missed check-in by 2 seconds.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues