[Elastic Agent] Add options to bootstrap Fleet Server with TLS #24142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
Pinging @elastic/agent (Team:Agent) |
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/test |
michalpristas
approved these changes
Feb 23, 2021
| return errors.New("certificate private key is required when certificate provided") | ||
| } | ||
| if c.options.FleetServerCertKey != "" && c.options.FleetServerCert == "" { | ||
| return errors.New("certificate is required when certificate private key is provided") |
There was a problem hiding this comment.
can we add TypeSecurity or TypeConfig here
There was a problem hiding this comment.
these are printed to stdout and not logged, so I think its best to just make them simple messages so its clear when using the CLI
| host = "localhost" | ||
| } | ||
| port := c.options.FleetServerPort | ||
| if port == 0 { |
There was a problem hiding this comment.
can this be negative?
There was a problem hiding this comment.
no its an uint16
Merged
3 tasks
blakerouse
added a commit
that referenced
this pull request
Mar 2, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds command line arguments to
enrollandinstallso Fleet Server can be bootstrapped with TLS enabled. By default if no options are provided a self-signed certificate is generated and the Elastic Agent communicates to the local bootstrapped Fleet Server with a pinned CA.Why is it important?
Required so Fleet Server is bootstrapped securely in the default case and provide the ability for custom certificates to be used for bootstrapping Fleet Server in production.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues