Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24564 to 7.12: Set event.type for Packetbeat flow events #24633

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 18, 2021

Cherry-pick of PR #24564 to 7.12 branch. Original message:

What does this PR do?

Add event.type: [connection] to flow events and include end for final flows.

Why is it important?

This helps the data comply to ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

  "event": {
    "type": [
      "connection",
      "end"
    ],
    "start": "2021-03-16T15:14:29.826Z",
    "end": "2021-03-16T15:14:29.826Z",
    "duration": 273694,
    "dataset": "flow",
    "kind": "event",
    "category": [
      "network"
    ],
    "action": "network_flow"
  }

Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit 7f35a78)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24633 updated

  • Start Time: 2021-03-18T22:01:46.836+0000

  • Duration: 37 min 2 sec

  • Commit: 2ff7590

Test stats 🧪

Test Results
Failed 0
Passed 4906
Skipped 45
Total 4951

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4906
Skipped 45
Total 4951

Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but seems to need an update

@andrewkroh andrewkroh merged commit 657ed08 into elastic:7.12 Mar 18, 2021
@zube zube bot removed the [zube]: Done label Jun 17, 2021
@andrewkroh andrewkroh deleted the backport_24564_7.12 branch January 14, 2022 14:05
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
)

Add `event.type: [connection]` to flow events and include `end` for final flows.

(cherry picked from commit f626a08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants