Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24664 to 7.x: [winlogbeat] Move windows event marhsaling to its own package #24705

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 23, 2021

Cherry-pick of PR #24664 to 7.x branch. Original message:

What does this PR do?

Moves decoding of windows events to its own package.

Why is it important?

To make it easier to reuse by other packages, i.e.: we are working on a processor that will use this code.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2021
…c#24664)

* Move windows event marhsaling to its own package

* Apply suggestion
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Marc Guasch

  • Start Time: 2021-03-24T07:55:20.684+0000

  • Duration: 57 min 42 sec

  • Commit: 15f2ad5

Test stats 🧪

Test Results
Failed 0
Passed 46284
Skipped 5146
Total 51430

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46284
Skipped 5146
Total 51430

@marc-gr marc-gr merged commit 888e323 into elastic:7.x Mar 24, 2021
@marc-gr marc-gr deleted the backport_24664_7.x branch March 24, 2021 09:19
@zube zube bot removed the [zube]: Done label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants