Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #24820 to 7.x: Add support for Filestream input in elastic agent. #24900

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Cherry-pick #24820 to 7.x: Add support for Filestream input in elastic agent. #24900

merged 1 commit into from
Apr 1, 2021

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 1, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24820 to 7.x branch. Original message:

Add support for the filestream input and regenerate the spec.

inputs:
 - type: filestream

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Add support for Filestream input in elastic agent. (elastic#24820)
0cb316c 
* Add support for Filestream input in elastic agent.

Add support for the filestream input and regenerate the spec.
```
inputs:
 - type: filestream
 ```

(cherry picked from commit 54f5cbf)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24900 opened

  • Start Time: 2021-04-01T13:40:53.871+0000

  • Duration: 80 min 19 sec

  • Commit: 0cb316c

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6532
Skipped 24
Total 6556

@blakerouse
Copy link
Contributor

@ph Is this until filestream becomes the default? I assume at some point logfile will point to filestream?

@blakerouse
Copy link
Contributor

Sorry didn't notice this was a cherry-pick. See the conversation on the original PR. Sorry for the noise!

@ph
Copy link
Contributor Author

ph commented Apr 1, 2021

@blakerouse It will eventually becomes the default, as soon as we have JSON decoding support we should move our internal collection to filestream, I'll make an issue for it. fyi @kvch

@ph ph merged commit 11a3bc5 into elastic:7.x Apr 1, 2021
@zube zube bot removed the [zube]: Done label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees
No one assigned
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @blakerouse