Remove FLEET_SERVER_POLICY_NAME from container command

[blakerouse]

What does this PR do?

Fixes an issue where FLEET_SERVER_POLICY_NAME was not being used and need to be removed.

Why is it important?

So FLEET_SERVER_POLICY_NAME doesn't exist.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• [ ] I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Closes [elastic-agent][container] FLEET_SERVER_POLICY_ID is ignored when enrolling #25136

[elasticmachine]

Pinging @elastic/agent (Team:Agent)

[ruflin]

Assuming the policy id works, do we even need support for the policy name?

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #25149 updated

• Start Time: 2021-04-21T19:03:26.031+0000

• Duration: 60 min 32 sec

• Commit: 0874adb

Test stats 🧪

Test	Results
Failed	0
Passed	6788
Skipped	16
Total	6804

Trends 🧪

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	6788
Skipped	16
Total	6804

[blakerouse]

@ruflin We don't have to, it just a convenience for the users. I am okay with removing it as well.

[ruflin]

I kind of like the convenience of it but I'm also a bit worried that names can change and not sure if users will really use it. What we should probably make easier is to find the id of a policy. I currently copy it from the Kibana url.

The other part I stumbled over is that on the command line, we only have --fleet-server-policy. Does this take a id and a name or only the id? Should we be more specific and call it --fleet-server-policy-id?

Supporting the name makes the code more complex at the moment so I would skip it if we can and it adds more Kibana logic, which I'm not a big fan of :-)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-25136 upstream/fix-25136
git merge upstream/master
git push upstream fix-25136

[blakerouse]

@ruflin The CLI command-line only allows the ID. I think with that, maybe we just remove name.

[ruflin]

Lets remove name, that should get rid of the confusion.

[blakerouse]

@ruflin I have updated this to remove the FLEET_SERVER_POLICY_NAME. Should be okay after FF being that the ENV was ignored anyway.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-25136 upstream/fix-25136
git merge upstream/master
git push upstream fix-25136

[ruflin]

++ on removing it. One minor comment. I think I miss why we care about the TokenPolicyName.