[Elastic Agent] Reduce log level for listener cleanup to debug #25274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
blakerouse
changed the title
ruflin
reviewed
Apr 23, 2021
| if err := os.Remove(path); err != nil { | ||
| log.Errorf("%s", errors.New(err, fmt.Sprintf("Failed to cleanup %s", path), errors.TypeFilesystem, errors.M("path", path))) | ||
| if err := os.Remove(path); err != nil && !os.IsNotExist(err) { | ||
| log.Debug("%s", errors.New(err, fmt.Sprintf("Failed to cleanup %s", path), errors.TypeFilesystem, errors.M("path", path))) |
There was a problem hiding this comment.
In which scenarios does the file not exists so the cleanup fails?
There was a problem hiding this comment.
I believe the case is when the temp directory is removed before the actually socket. So that cause it to fail on the removal.
There was a problem hiding this comment.
But what removes the temp directory? BTW, don't want to block this PR on this but would be good to understand why it happens.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ruflin
approved these changes
Apr 26, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Cleanup log message for cleanupListener. * Add changelog. (cherry picked from commit 08b0159)
mergify bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Cleanup log message for cleanupListener. * Add changelog. (cherry picked from commit 08b0159)
blakerouse
added a commit
that referenced
this pull request
Apr 27, 2021
blakerouse
added a commit
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleans up the log message when removing the listener socket fails.
Why is it important?
So its not reported or confusing to users, its okay if it fails.
Checklist
[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues