Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain the zookeeper server id from its logs #25546

Merged
merged 4 commits into from
May 11, 2021
Merged

Obtain the zookeeper server id from its logs #25546

merged 4 commits into from
May 11, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 5, 2021 •
edited
Loading

What does this PR do?

Store the zookeeper server id when available in the server logs.

Why is it important?

To identify specific members in a cluster.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. (Not added, module not released yet)

Related issues

@jsoriano jsoriano added review Team:Integrations Label for the Integrations team labels May 5, 2021
@jsoriano jsoriano self-assigned this May 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 5, 2021
@jsoriano jsoriano mentioned this pull request May 5, 2021
Merged
6 tasks
@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label May 5, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25546 updated

  • Start Time: 2021-05-05T11:52:44.957+0000

  • Duration: 121 min 0 sec

  • Commit: 58d5eff

Test stats 🧪

Test Results
Failed 0
Passed 7010
Skipped 1193
Total 8203

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7010
Skipped 1193
Total 8203

@jsoriano jsoriano mentioned this pull request May 5, 2021
Merged
6 tasks
sayden
sayden approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit 22395f7 into elastic:master May 11, 2021
@jsoriano jsoriano deleted the zookeeper-id-logs branch May 11, 2021 11:12
@jsoriano jsoriano added backport-v7.14.0 Automated backport with mergify and removed needs_backport PR is waiting to be backported to other branches. labels May 11, 2021
mergify bot pushed a commit that referenced this pull request May 11, 2021
@jsoriano
Obtain the zookeeper server id from its logs (#25546)
3eaa06d 
Store the zookeeper server id when available in the server logs.

(cherry picked from commit 22395f7)
@mergify mergify bot mentioned this pull request May 11, 2021
Merged
jsoriano added a commit that referenced this pull request May 11, 2021
@mergify @jsoriano
Obtain the zookeeper server id from its logs (#25546) (#25658)
790712f 
Store the zookeeper server id when available in the server logs.

(cherry picked from commit 22395f7)

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@jsoriano jsoriano

Labels
backport-v7.14.0 Automated backport with mergify review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @sayden