Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude builds with changes on the k8s templates files #25864

Merged
merged 1 commit into from
May 27, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented May 26, 2021

What does this PR do?

deploy/kubernetes/.*-kubernetes.yaml files are templates for the docs

Why is it important?

Filter what to run for those builds with docs changes.

Issue

Tested with elastic/apm-pipeline-library#1131

@v1v v1v requested review from urso, andresrc and a team May 26, 2021 08:21
@v1v v1v self-assigned this May 26, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 26, 2021
@v1v v1v added backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label labels May 26, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 26, 2021
@botelastic
Copy link

botelastic bot commented May 26, 2021

This pull request doesn't have a Team:<team> label.

@andresrc
Copy link
Contributor

@elastic/integrations are these files used for something else?

@ChrsMark
Copy link
Member

@elastic/integrations are these files used for something else?

These files are used in docs as reference, and as reference in general. We don't test sth on top of these explicitly. I think that we only check if they are able to be deployed at

for FILE in $(shell ls *-kubernetes.yaml); do \
, not 100% sure though so feel free to correct me.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25864 opened

  • Start Time: 2021-05-26T08:21:24.858+0000

  • Duration: 139 min 40 sec

  • Commit: 5db13e6

Test stats 🧪

Test Results
Failed 0
Passed 47529
Skipped 5257
Total 52786

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 47529
Skipped 5257
Total 52786

@andresrc
Copy link
Contributor

@ChrsMark do we know where we call make test for that folder?

@v1v
Copy link
Member Author

v1v commented May 27, 2021

The deploys/k8s folder has got a pipeline:

make test runs in the linting stage with the make all -> https://github.com/elastic/beats/blob/master/deploy/kubernetes/Makefile#L6

Linting is mandatory for every PR, including docs only.

I think we should be good with this, if my assumption is correct

@andresrc
Copy link
Contributor

Thanks @ChrsMark ! @v1v linting would run anyway with this change, wouldn't it?

@v1v
Copy link
Member Author

v1v commented May 27, 2021

Yes,

beats/Jenkinsfile

Lines 82 to 102 in 9e5aafd

stage('Lint'){
options { skipDefaultCheckout() }
environment {
GOFLAGS = '-mod=readonly'
}
steps {
stageStatusCache(id: 'Lint'){
withGithubNotify(context: "Lint") {
withBeatsEnv(archive: false, id: "lint") {
dumpVariables()
whenTrue(env.ONLY_DOCS == 'true') {
cmd(label: "make check", script: "make check")
}
whenTrue(env.ONLY_DOCS == 'false') {
runLinting()
}
}
}
}
}
}
for only docs it will run the make check that IIUC, it's the meta make goal to run all the linting for all the beats.

@v1v v1v merged commit 7ba5980 into elastic:master May 27, 2021
@v1v v1v deleted the feature/exclude-k8s-template-from-build branch May 27, 2021 10:08
mergify bot pushed a commit that referenced this pull request May 27, 2021
(cherry picked from commit 7ba5980)

# Conflicts:
#	Jenkinsfile
mergify bot pushed a commit that referenced this pull request May 27, 2021
(cherry picked from commit 7ba5980)

# Conflicts:
#	Jenkinsfile
mergify bot pushed a commit that referenced this pull request May 27, 2021
(cherry picked from commit 7ba5980)

# Conflicts:
#	Jenkinsfile
v1v pushed a commit that referenced this pull request Jun 23, 2021
v1v pushed a commit that referenced this pull request Jun 23, 2021
v1v pushed a commit that referenced this pull request Jun 23, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants