Increase wait time to stabilize TestRotateDateSuffix
#25869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
mtojek
reviewed
May 26, 2021
| @@ -216,15 +216,15 @@ func TestRotateDateSuffix(t *testing.T) { | |||
| firstExpectedPattern := fmt.Sprintf("%s-%s.*", logname, time.Now().Format("20060102150405")) | |||
| AssertDirContentsPattern(t, dir, firstExpectedPattern) | |||
|
|
|||
| time.Sleep(1500 * time.Millisecond) | |||
| time.Sleep(2 * time.Second) | |||
There was a problem hiding this comment.
I understand this is a quick fix, but in general this is an antipattern as it elongates the test execution. Do you think it's possible to replace it with mocked time instance?
For reference: https://github.com/benbjohnson/clock
There was a problem hiding this comment.
It is indeed not the best solution. It is possible to refactor the code, however, I do not think it worth saving a few seconds when the whole build process for touching libbeat takes 2-3 hours.
There was a problem hiding this comment.
I understand your concerns, but it's definitely a code smell. I suggest to open a followup Beats issue to fix this test.
mtojek
approved these changes
May 26, 2021
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 3 |
| Passed | 18225 |
| Skipped | 1478 |
| Total | 19706 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / metricbeat-goIntegTest / TestFetch – github.com/elastic/beats/v7/metricbeat/module/couchbase/bucket - Name:
Build&Test / metricbeat-goIntegTest / TestFetch – github.com/elastic/beats/v7/metricbeat/module/couchbase/cluster - Name:
Build&Test / metricbeat-goIntegTest / TestFetch – github.com/elastic/beats/v7/metricbeat/module/couchbase/node
kvch
added
backport-v7.13.0
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2021
(cherry picked from commit 9e5aafd)
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2021
(cherry picked from commit 9e5aafd)
kvch
added a commit
that referenced
this pull request
May 27, 2021
kvch
added a commit
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR increases the wait time to make sure files get rotated enough times.
Why is it important?
The test has been flaky.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #25868