Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o365: Support non-array Parameters and ExtendedProperties fields #26164

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jun 7, 2021

These fields are documented as being an array of Name-value pairs. However, in some cases they appear as a string field, leading to mapping errors.

This patch will perform the expected name-value conversion by creating a new key, _raw with the original field value, when the fields are not arrays.

These fields are documented as being an array of Name-value pairs.
However, in some cases they appear as a string field, leading to mapping
errors.

This patch will perform the expected name-value conversion by creating a
new key, "_raw" with the original field value, when the fields are not
arrays.
@adriansr adriansr added bug review Team:Security-External Integrations backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Jun 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 7, 2021
@adriansr adriansr requested a review from P1llus June 7, 2021 10:28
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26164 opened

  • Start Time: 2021-06-07T10:28:16.885+0000

  • Duration: 106 min 10 sec

  • Commit: 9119ebd

Test stats 🧪

Test Results
Failed 0
Passed 7195
Skipped 1193
Total 8388

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7195
Skipped 1193
Total 8388

@adriansr adriansr merged commit 07fa7f6 into elastic:master Jun 7, 2021
mergify bot pushed a commit that referenced this pull request Jun 7, 2021
)

These fields are documented as being an array of Name-value pairs.
However, in some cases they appear as a string field, leading to mapping
errors.

This patch will perform the expected name-value conversion by creating a
new key, "_raw" with the original field value, when the fields are not
arrays.

(cherry picked from commit 07fa7f6)
mergify bot pushed a commit that referenced this pull request Jun 7, 2021
)

These fields are documented as being an array of Name-value pairs.
However, in some cases they appear as a string field, leading to mapping
errors.

This patch will perform the expected name-value conversion by creating a
new key, "_raw" with the original field value, when the fields are not
arrays.

(cherry picked from commit 07fa7f6)
adriansr pushed a commit that referenced this pull request Jun 9, 2021
…dProperties fields (#26169)

These fields are documented as being an array of Name-value pairs.
However, in some cases they appear as a string field, leading to mapping
errors.

This patch will perform the expected name-value conversion by creating a
new key, "_raw" with the original field value, when the fields are not
arrays.

(cherry picked from commit 07fa7f6)
adriansr pushed a commit that referenced this pull request Jun 9, 2021
…edProperties fields (#26170)

These fields are documented as being an array of Name-value pairs.
However, in some cases they appear as a string field, leading to mapping
errors.

This patch will perform the expected name-value conversion by creating a
new key, "_raw" with the original field value, when the fields are not
arrays.

(cherry picked from commit 07fa7f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify bug review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants