Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oracle] Fixing default values for paths in config template #26276

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jun 14, 2021

What does this PR do?

Fixes some default values for paths and updates the default config with the correct format for paths

Why is it important?

Makes sure the module does not error when starting up for the first time with default settings.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 14, 2021
@P1llus P1llus changed the title fixing some typos in the default oracle config, and adding default va… [Oracle] Fixing default values for paths in config template Jun 14, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26276 updated

  • Start Time: 2021-06-14T09:36:33.337+0000

  • Duration: 95 min 25 sec

  • Commit: 8b8cc99

Test stats 🧪

Test Results
Failed 0
Passed 7313
Skipped 1193
Total 8506

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7313
Skipped 1193
Total 8506

@P1llus P1llus merged commit 81e5cc0 into elastic:master Jun 14, 2021
@P1llus P1llus added the backport-v7.14.0 Automated backport with mergify label Jun 14, 2021
mergify bot pushed a commit that referenced this pull request Jun 14, 2021
* fixing some typos in the default oracle config, and adding default values

* adding changelog entry

(cherry picked from commit 81e5cc0)
P1llus added a commit that referenced this pull request Jun 14, 2021
…26281)

* fixing some typos in the default oracle config, and adding default values

* adding changelog entry

(cherry picked from commit 81e5cc0)

Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Jun 17, 2021
…26276)

* fixing some typos in the default oracle config, and adding default values

* adding changelog entry
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
* master: (26 commits)
  Report total and free CPU for vSphere virtual machines (elastic#26167)
  [filebeat] Add preserve_original_event option to o365audit input (elastic#26273)
  Change xml processor names in script processor to match convention (elastic#26263)
  [Oracle] Fixing default values for paths in config template (elastic#26276)
  Add more ECS fields to logs (elastic#25998)
  [Heartbeat] Fix broken invocation of synth package (elastic#26228)
  rename sqs file name (elastic#26227)
  Populate the agent action result if there is no matching action handlers (elastic#26152)
  Add ISO8601 as supported timestamp type (elastic#25564)
  Move Filebeat azure module to GA (elastic#26168)
  Filebeat azure module pipeline fixes and changes (elastic#26148)
  libbeat: monitor version (elastic#26214)
  Add new parser to filestream input: container (elastic#26115)
  [Metricbeat] Add state_statefulset replicas.ready (elastic#26088)
  Disable test processors system test for windows 10 (elastic#26216)
  Fix startup with failing configuration (elastic#26126)
  Remove 32 bits version of Elastic Agent. (elastic#25708)
  Chane fleetmode detection to ony use management.enabled (elastic#26180)
  Make `filestream` input GA (elastic#26127)
  libbeat/idxmgmt/ilm: fix alias creation (elastic#26146)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants